updating package to work on modern nim versions#21
Open
samdmarshall wants to merge 1 commit into
Open
Conversation
* commandeer.nim :modified: - changing import to new std/parseopt - changing types to tuples for accessing the parseopt types * commandeer.nimble :modified: - bumping version number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently had to rebuild a bunch of personal command line tools using a modern version of nim-lang and found I had to make updates to this as a dependency to compile on version 2.2.10 of the language. I've made my own fork to resolve my local build dependencies but wanted to contribute this small change upstream incase anyone else wants to continue using this as well.
I ran the tests locally on an arm64 Mac and they all seem to pass with this change.